tngo/product-recognition-demo
1
0
Fork 0
forked from vnguyen/product-recognition-demo
Code Pull requests Activity

Fix the decision ceiling to count enrolled facings only

Browse source 
The text lane can answer an unenrolled sibling correctly, and those answers
were counted in a ratio whose denominator is the enrolled count, so the
ceiling read 117%. It now reads 86% for the local lane, which is the number
the docstring always described.
This commit is contained in:
tngo 2026-09-29 02:09:46 +09:00
parent bf9c04bce4
commit 4c32e120ec
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
recognization/code/eval_identity.py
View file

@ -487,6 +487,10 @@ def score_lane(
unenrolled_count = len(in_catalog) - enrolled_count unenrolled_count = len(in_catalog) - enrolled_count
correct = wrong = rejected = top1_correct = 0 correct = wrong = rejected = top1_correct = 0
# The decision ceiling is over enrolled facings only. The text lane can
# answer an unenrolled sibling correctly, and counting that in a ratio
# whose denominator is the enrolled count reports a ceiling above 100%.
enrolled_correct = 0
unknown_false = unenrolled_false = 0 unknown_false = unenrolled_false = 0
accepts: Counter = Counter() accepts: Counter = Counter()
per_sku: Dict[str, List[int]] = {} per_sku: Dict[str, List[int]] = {}
@ -510,6 +514,8 @@ def score_lane(
if answered == truth: if answered == truth:
correct += 1 correct += 1
bucket[0] += 1 bucket[0] += 1
if truth in enrolled_skus:
enrolled_correct += 1
elif answered: elif answered:
wrong += 1 wrong += 1
if truth not in enrolled_skus: if truth not in enrolled_skus:
@ -537,7 +543,7 @@ def score_lane(
"rejected": rejected, "rejected": rejected,
"catalog_ceiling": round(enrolled_count / len(in_catalog), 4) if in_catalog else None, "catalog_ceiling": round(enrolled_count / len(in_catalog), 4) if in_catalog else None,
"identity_ceiling": round(top1_correct / enrolled_count, 4) if enrolled_count else None, "identity_ceiling": round(top1_correct / enrolled_count, 4) if enrolled_count else None,
"decision_ceiling": round(correct / enrolled_count, 4) if enrolled_count else None, "decision_ceiling": round(enrolled_correct / enrolled_count, 4) if enrolled_count else None,
"end_to_end_coverage": round(correct / len(in_catalog), 4) if in_catalog else None, "end_to_end_coverage": round(correct / len(in_catalog), 4) if in_catalog else None,
"false_accepts": wrong, "false_accepts": wrong,
"unknown_false_accepts": unknown_false, "unknown_false_accepts": unknown_false,